Re: [PATCH] Fix style issues in kernel/cpu.c

[Sebastian Andrzej Siewior]

On 2016-12-03 01:09:58 [+0000], Thomas Casey wrote:
> This patch fixes style issues in kernel/cpu.c such as wrapping an 80
> character line, calling EXPORT_SYMBOL() immediately after a function is
> defined, and whitespace and spacing issues.
> 
> Signed-off-by: Thomas Casey <tqcasey@xxxxxxxxx>

This is okay for most of it.

> --- a/kernel/cpu.c
> +++ b/kernel/cpu.c
> @@ -353,6 +354,7 @@ EXPORT_SYMBOL_GPL(cpu_hotplug_enable);
>  int register_cpu_notifier(struct notifier_block *nb)
>  {
>  	int ret;
> +
>  	cpu_maps_update_begin();
>  	ret = raw_notifier_chain_register(&cpu_chain, nb);
>  	cpu_maps_update_done();
> @@ -363,6 +365,7 @@ int __register_cpu_notifier(struct notifier_block *nb)
>  {
>  	return raw_notifier_chain_register(&cpu_chain, nb);
>  }
> +EXPORT_SYMBOL(__register_cpu_notifier);
>  
>  static int __cpu_notify(unsigned long val, unsigned int cpu, int nr_to_call,
>  			int *nr_calls)
> @@ -661,7 +664,6 @@ void __init cpuhp_threads_init(void)
>  
>  #ifdef CONFIG_HOTPLUG_CPU
>  EXPORT_SYMBOL(register_cpu_notifier);
> -EXPORT_SYMBOL(__register_cpu_notifier);
>  void unregister_cpu_notifier(struct notifier_block *nb)
>  {
>  	cpu_maps_update_begin();

I have a patch posted which gets rid of register_cpu_notifier() and
__register_cpu_notifier() so there is probably no point in fixing /
changing those.

Sebastian