Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

[Santosh Shilimkar]

On 12/7/2016 7:55 AM, David Miller wrote:
> From: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx>
> Date: Tue,  6 Dec 2016 20:01:56 -0800
>
> > rds-tools already support it.
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxxxxxx>
> > ---
> >  include/uapi/linux/rds.h | 1 +
> >  net/rds/ib.c             | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
> > index 3833113..410ae3c 100644
> > --- a/include/uapi/linux/rds.h
> > +++ b/include/uapi/linux/rds.h
> > @@ -183,6 +183,7 @@ struct rds_info_rdma_connection {
> >  	uint32_t	max_send_sge;
> >  	uint32_t	rdma_mr_max;
> >  	uint32_t	rdma_mr_size;
> > +	uint32_t	cache_allocs;
> >  };
> >
> >  /* RDS message Receive Path Latency points */
>
> What level of compatability exists here?  If we run an old tool on a new
> kernel, or a new tool on an old kernel, does it work properly?
Tools repo carries a copy of the header and thats how the old tool and
new tools have been running with older/newer kernels. There are few more
bits left before I can start using directly kernel header for newer
tools.

Moreover this particular parameter is only used for verbose mode which
isn't used in default options.

Regards,
Santosh