[PATCH 09/10] perf sched timehist: Cleanup idle_max_cpu handling
From: Arnaldo Carvalho de Melo
Date: Wed Dec 07 2016 - 11:54:47 EST
From: Namhyung Kim <namhyung@xxxxxxxxxx>
It treats the idle_max_cpu little bit confusingly IMHO. Let's make it
more straight forward.
Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
Acked-by: David Ahern <dsahern@xxxxxxxxx>
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
Cc: Minchan Kim <minchan@xxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Link: http://lkml.kernel.org/r/20161206034010.6499-6-namhyung@xxxxxxxxxx
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
tools/perf/builtin-sched.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index c8b3e6c330c3..1a3f1be93372 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -2010,7 +2010,7 @@ static int init_idle_threads(int ncpu)
if (!idle_threads)
return -ENOMEM;
- idle_max_cpu = ncpu - 1;
+ idle_max_cpu = ncpu;
/* allocate the actual thread struct if needed */
for (i = 0; i < ncpu; ++i) {
@@ -2031,7 +2031,7 @@ static void free_idle_threads(void)
if (idle_threads == NULL)
return;
- for (i = 0; i <= idle_max_cpu; ++i) {
+ for (i = 0; i < idle_max_cpu; ++i) {
if ((idle_threads[i]))
thread__delete(idle_threads[i]);
}
@@ -2054,8 +2054,7 @@ static struct thread *get_idle_thread(int cpu)
return NULL;
idle_threads = (struct thread **) p;
- i = idle_max_cpu ? idle_max_cpu + 1 : 0;
- for (; i < j; ++i)
+ for (i = idle_max_cpu; i < j; ++i)
idle_threads[i] = NULL;
idle_max_cpu = j;
@@ -2495,7 +2494,7 @@ static void timehist_print_summary(struct perf_sched *sched,
return;
printf("\nIdle stats:\n");
- for (i = 0; i <= idle_max_cpu; ++i) {
+ for (i = 0; i < idle_max_cpu; ++i) {
t = idle_threads[i];
if (!t)
continue;
--
2.9.3