Re: [PATCH v8 8/8] cpufreq: intel_pstate: Use CPPC to get max performance

[Tim Chen]

On Wed, 2016-12-07 at 20:06 +0100, Sebastian Andrzej Siewior wrote:
>Â
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> Âdrivers/acpi/cppc_acpi.c | 3 +++
> Â1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index d0d0504b7c89..93252e5374c5 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -803,6 +803,7 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
> Â		if (addr)
> Â			iounmap(addr);
> Â	}
> +	per_cpu(cpc_desc_ptr, pr->id) = NULL;
> Â	kfree(cpc_ptr);
> Â
> Âout_buf_free:
> @@ -824,6 +825,8 @@ void acpi_cppc_processor_exit(struct acpi_processor *pr)
> Â	void __iomem *addr;
> Â
> Â	cpc_ptr = per_cpu(cpc_desc_ptr, pr->id);
> +	if (!cpc_ptr)
> +		return;

I agree that not handling null pointer here is a bug that should be fixed.
The cpc_ptr is checked at other places like acpi_get_psd_map. Â
We could potentially have a null cpc_ptr say when
the parsing of CPC table failed. We should handle such cases gracefully.

Tim