Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration
From: Scott Wood
Date: Thu Dec 08 2016 - 18:36:07 EST
On 12/08/2016 05:10 PM, sboyd@xxxxxxxxxxxxxx wrote:
> On 11/25, Y.T. Tang wrote:
>> Hi Scott,
>>
>>> -----Original Message-----
>>> From: Scott Wood
>>> Sent: Thursday, November 24, 2016 4:21 PM
>>> To: Y.T. Tang <yuantian.tang@xxxxxxx>; mturquette@xxxxxxxxxxxx
>>> Cc: sboyd@xxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; linux-
>>> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>>> Subject: Re: [PATCH v3] clk: qoriq: added ls1012a clock configuration
>>>
>>> On 11/23/2016 08:50 PM, yuantian.tang@xxxxxxx wrote:
>>>> From: Tang Yuantian <Yuantian.Tang@xxxxxxx>
>>>>
>>>> Signed-off-by: Tang Yuantian <yuantian.tang@xxxxxxx>
>>>> ---
>>>> v3:
>>>> - rebased to latest kernel and re-sorted the code
>>> [snip]
>>>> @@ -1316,6 +1334,7 @@ CLK_OF_DECLARE(qoriq_clockgen_2,
>>>> "fsl,qoriq-clockgen-2.0", clockgen_init);
>>>> CLK_OF_DECLARE(qoriq_clockgen_ls1021a, "fsl,ls1021a-clockgen",
>>>> clockgen_init); CLK_OF_DECLARE(qoriq_clockgen_ls1043a,
>>>> "fsl,ls1043a-clockgen", clockgen_init);
>>>> CLK_OF_DECLARE(qoriq_clockgen_ls1046a, "fsl,ls1046a-clockgen",
>>>> clockgen_init);
>>>> +CLK_OF_DECLARE(qoriq_clockgen_ls1012a, "fsl,ls1012a-clockgen",
>>>> +clockgen_init);
>>>> CLK_OF_DECLARE(qoriq_clockgen_ls2080a, "fsl,ls2080a-clockgen",
>>>> clockgen_init);
>>>
>>> You need a better sorting algorithm. :-P
>>>
>> I don't think so. This time, each code snip goes right after ls1046a.
>> The sorting 'algorithm' is best ever. :)
>>
>
> I will sort it and apply it? Ack Scott?
>
Acked-by: Scott Wood <oss@xxxxxxxxxxxx>
-Scott