Re: [patch] nvme-fabrics: correct some printk information

From: Joe Perches
Date: Sat Dec 10 2016 - 17:24:31 EST


On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > --- drivers//dma/pxa_dma.c
> > +++ /tmp/nothing//dma/pxa_dma.c
> > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc
> > dcsr = phy_readl_relaxed(phy, DCSR);
> > phy_writel(phy, dcsr, DCSR);
> > if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))
> > - dev_warn(&phy->vchan->vc.chan.dev->device,
> > - "%s(chan=%p): PXA_DCSR_BUSERR\n",
> > - __func__, &phy->vchan);
>
> That's not a defect. We're getting the address of vchan. I don't get
> it?

$ git grep -n -w vchan drivers/dma/pxa*
drivers/dma/pxa_dma.c:103: struct pxad_chan *vchan;