Re: [PATCH 3/8] rtc: add STM32 RTC driver

From: Amelie DELAUNAY
Date: Mon Dec 12 2016 - 05:00:58 EST


Hi Alexandre,

On 12/07/2016 07:37 PM, Alexandre Belloni wrote:
On 05/12/2016 at 10:43:14 +0100, Amelie DELAUNAY wrote :
+
+ device_init_wakeup(&pdev->dev, true);

What happens if device_init_wakeup() returns an error?
It means that RTC won't be able to wake up the board with RTC alarm. I can
add a warning for the user in this case ?


There is exactly one driver ever checking the return value of
device_init_wakeup(). It basically always succeeds.


OK so, is it OK for everyone that I bet on the fact that it will always succeed?