Re: [PATCH 1/5] perf mem: Fix --all-user/--all-kernel options

[Jiri Olsa]

On Mon, Dec 12, 2016 at 10:43:11AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Dec 12, 2016 at 11:35:39AM +0100, Jiri Olsa escreveu:
> > Removing extra '--' prefix.
> 
> Please add a Fixes: tag in such cases, as this helps backporters to
> figure out what affects packages they published, in this case I'm
> adding:
> 
> Fixes: ad16511b0e40 ("perf mem: Add -U/-K (--all-user/--all-kernel)
> options")
> 
> And I just added this to the Todo[1] list:
> 
> * Improve git pre-commit hook script to check for OPTION() with -- in
>   its name, to fix bugs like ad16511b0e40 ("perf mem: Add -U/-K
>   (--all-user/--all-kernel) options") (acme) 
> 
> :-)

I forgot ;-) thanks

jirka

> 
> Thanks,
> 
> - Arnaldo
> 
> [1] https://perf.wiki.kernel.org/index.php/Todo
>  
> > Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> > Cc: David Ahern <dsahern@xxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> > Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > Link: http://lkml.kernel.org/n/tip-p8x8lf2ekjpqc2x5ixw61505@xxxxxxxxxxxxxx
> > ---
> >  tools/perf/builtin-mem.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
> > index d1ce29be560e..cd7bc4d104e2 100644
> > --- a/tools/perf/builtin-mem.c
> > +++ b/tools/perf/builtin-mem.c
> > @@ -70,8 +70,8 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
> >  	OPT_UINTEGER(0, "ldlat", &perf_mem_events__loads_ldlat, "mem-loads latency"),
> >  	OPT_INCR('v', "verbose", &verbose,
> >  		 "be more verbose (show counter open errors, etc)"),
> > -	OPT_BOOLEAN('U', "--all-user", &all_user, "collect only user level data"),
> > -	OPT_BOOLEAN('K', "--all-kernel", &all_kernel, "collect only kernel level data"),
> > +	OPT_BOOLEAN('U', "all-user", &all_user, "collect only user level data"),
> > +	OPT_BOOLEAN('K', "all-kernel", &all_kernel, "collect only kernel level data"),
> >  	OPT_END()
> >  	};
> >  
> > -- 
> > 2.7.4