Re: [PATCH] keys/encrypted: Fix two crypto-on-the-stack bugs

From: David Howells
Date: Mon Dec 12 2016 - 17:28:33 EST


Andy Lutomirski <luto@xxxxxxxxxx> wrote:

> +static const char zero_pad[16] = {0};

Isn't there a global page of zeros or something that we can share? Also, you
shouldn't explicitly initialise it so that it stays in .bss.

> - sg_set_buf(&sg_out[1], pad, sizeof pad);
> + sg_set_buf(&sg_out[1], zero_pad, sizeof zero_pad);

Can you put brackets on the sizeof?

Thanks,
David