Re: [PATCH v3 6/6] mfd: dt: Move syscon bindings to syscon subdirectory

[Lee Jones]

On Tue, 13 Dec 2016, Andrew Jeffery wrote:

> On Mon, 2016-12-12 at 09:39 -0600, Rob Herring wrote:
> > On Tue, Dec 06, 2016 at 01:53:21PM +1100, Andrew Jeffery wrote:
> > > The use of syscons is growing, lets collate them in their own part of
> > > the bindings tree.
> > > 
> > > > > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > > ---
> > > ÂDocumentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txtÂÂÂÂÂÂÂÂÂ| 0
> > > ÂDocumentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txtÂÂÂÂÂÂÂÂÂ| 0
> > > ÂDocumentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txtÂÂÂÂÂÂÂ| 0
> > > ÂDocumentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txtÂÂÂÂÂÂÂÂÂÂ| 0
> > > ÂDocumentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txtÂÂÂÂÂÂÂÂÂÂ| 0
> > > ÂDocumentation/devicetree/bindings/mfd/{ => syscon}/syscon.txtÂÂÂÂÂÂÂÂÂÂÂÂÂ| 0
> > > Â.../devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txtÂÂÂÂÂÂÂÂÂÂ| 0
> > > Â7 files changed, 0 insertions(+), 0 deletions(-)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/aspeed-scu.txt (100%)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-gpbr.txt (100%)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-matrix.txt (100%)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/atmel-smc.txt (100%)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/qcom,tcsr.txt (100%)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/syscon.txt (100%)
> > > Ârename Documentation/devicetree/bindings/mfd/{ => syscon}/ti-keystone-devctrl.txt (100%)
> > 
> > I'm not so sure this is the right direction. syscon usage is pretty muchÂ
> > spread throughout the tree.
> 
> This patch was created based on my interpretation of Lee's feedback
> here:
> 
> https://lkml.org/lkml/2016/11/18/650
> 
> Lee's next email in the chain poked Arnd for an opinion, but Arnd
> didn't reply.
> 
> I don't mind. I moved these bindings separately so we could just drop
> the patch if there was push-back. If we drop the whole idea I'll need
> to apply a small fix to patch 5/6 to avoid creating the syscon
> subdirectory.

The sub-directory is a good idea for drivers who are *solely* syscon
based.



-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog