Re: /drivers/char/Kconfig Bug Kernel Patch

[Max Bires]

On Tue, Dec 13, 2016 at 1:37 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Tuesday, December 13, 2016 1:30:39 PM CET Max Bires wrote:
> > While trying to turn off the port device in defconfig, I ran into a bug
> > caused by the fact that the Kconfig for port didn't have a string after the
> > bool declaration. I fixed this in the attached patch (though I figure the
> > description might need tuning up). Let me know if there's anything else I
> > need to do.
>
> The change looks reasonable, however there are a few things to improve
> to get the patch applied:
>
> - clarify that the current behavior is not a bug, but was done intentionally.
> Â Making the option user-visible would help avoid a potential attack vector
> Â and make the kernel smaller, both of which are useful.
>
> - remove the "Change-id" line from the submission, it has no meaning in
> Â an upstream kernel
>
> - send the patch inline rather than as an attachment, this is usually done
> Â with git-send-email.
>
> Â Â Â Â Arnd
-First and second points have been addressed; I had some trouble with
send-email, so let me know if the following isn't acceptable inlining.