Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()

[Andy Shevchenko]

On Sun, Dec 11, 2016 at 12:40 PM, Pali RohÃr <pali.rohar@xxxxxxxxx> wrote:
> On Thursday 08 December 2016 13:36:15 MichaÅ KÄpieÅ wrote:
>> All calls to dell_app_wmi_led_set() have been replaced with direct
>> calls to dell_micmute_led_set(), so the former can be safely removed
>> along with its related enum.
>>
>> Signed-off-by: MichaÅ KÄpieÅ <kernel@xxxxxxxxxx>
>
> I would suggest to squash patches 2,3,4 into one. But I let decision to
> alsa & led maintainers.

I don't like the part where we are exporting something for just one
moment. So, +1 to squashed version.

>
> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup
>
> Reviewed-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
>
> --
> Pali RohÃr
> pali.rohar@xxxxxxxxx



-- 
With Best Regards,
Andy Shevchenko