Re: [PATCH] arm: dt: Initialize boot_command_line from CONFIG_CMDLINE in case DT does not provide /chosen/bootargs

From: Tony Lindgren
Date: Wed Dec 14 2016 - 16:47:40 EST


* Pavel Machek <pavel@xxxxxx> [161214 13:26]:
> On Wed 2016-12-14 22:12:43, Pali RohÃr wrote:
> > Commit 008a2ebcd677 ("ARM: dts: omap3: Remove skeleton.dtsi usage") broke
> > support for setting cmdline on Nokia N900 via CONFIG_CMDLINE.
> >
> > It is because arm code booted in DT mode parse cmdline only via function
> > early_init_dt_scan_chosen() and that function does not fill variable
> > boot_command_line when DTB does not contain /chosen entry. It is called
> > from function early_init_dt_scan_nodes() in setup_machine_fdt().
> >
> > This patch fixes it by explicitly filling boot_command_line in function
> > setup_machine_fdt() after calling early_init_dt_scan_nodes() in case
> > boot_command_line still remains empty.
> >
> > Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
>
> Acked-by: Pavel Machek <pavel@xxxxxx>

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>