[RFC v2 5/5] rcu: Use for_each_leaf_node_cpu() in online CPU iteration
From: Boqun Feng
Date: Wed Dec 14 2016 - 21:44:29 EST
Though mostly identical, ->qsmaskinit(A.K.A rcu_rnp_online_cpus()) is
sometimes more sparse than the corresponding part of cpu_possible_mask
for an RCU leaf node. So we use for_each_leaf_node_cpu() in
rcu_boost_kthread_setaffinity() instead to save some extra checks.
Signed-off-by: Boqun Feng <boqun.feng@xxxxxxxxx>
---
kernel/rcu/tree_plugin.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 69c6eb27c37f..93cebd940a93 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -1175,10 +1175,11 @@ static void rcu_boost_kthread_setaffinity(struct rcu_node *rnp, int outgoingcpu)
return;
if (!zalloc_cpumask_var(&cm, GFP_KERNEL))
return;
- for_each_leaf_node_possible_cpu(rnp, cpu)
- if ((mask & leaf_node_cpu_bit(rnp, cpu)) &&
- cpu != outgoingcpu)
+
+ for_each_leaf_node_cpu(rnp, mask, cpu)
+ if (cpu != outgoingcpu)
cpumask_set_cpu(cpu, cm);
+
if (cpumask_weight(cm) == 0)
cpumask_setall(cm);
set_cpus_allowed_ptr(t, cm);
--
2.10.2