RE: [PATCH 1/3] dmaengine: xilinx_dma: Check for channel idle state before submitting dma descriptor

From: Appana Durga Kedareswara Rao
Date: Thu Dec 15 2016 - 13:52:53 EST


Hi Jose Miguel Abreu,

Thanks for the review...


> > + chan->idle = true;
> >
> > spin_lock_init(&chan->lock);
> > INIT_LIST_HEAD(&chan->pending_list);
>
> I think there is missing a set to true in idle when a channel reset is performed.
> Otherwise: Reviewed-by: Jose Abreu <joabreu@xxxxxxxxxxxx>

Sure will fix in v2...

Regards,
Kedar.

>
> Best regards,
> Jose Miguel Abreu