Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip()

From: Radim KrÄmÃÅ
Date: Fri Dec 16 2016 - 10:44:17 EST


2016-12-16 16:25+0100, Paolo Bonzini:
> On 16/12/2016 16:10, Radim KrÄmÃÅ wrote:
>> + bool ret = irqchip_kernel(kvm) || irqchip_split(kvm);
>
> bool ret = (kvm->arch.irqchip_mode != KVM_IRQCHIP_NONE);
>
> :)

(That imposes an assumption that we will only add in-kernel irqchips!
Are we willing to sell our souls for faster code? :])

I'll use that line without parentheses, thanks.