Re: [PATCH 1/1] tools: net: bpf_dbg.c fixed keyboard typo

[Ozgur Karatas]

16.12.2016, 21:08, "Sergei Shtylyov" <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>:
> Hello.

Hi

> On 12/16/2016 09:21 PM, Ozgur Karatas wrote:
>
>> ÂThis patch fixed to keyboard typo, brackets not closed.
>> ÂI think, it should be close to parenthes.
>>
>> ÂSigned-off-by: Ozgur Karatas <okaratas@xxxxxxxxxxxxxx>
>> Â---
>> ÂÂtools/net/bpf_dbg.c | 2 +-
>> ÂÂ1 files changed, 1 insertion(+), 1 deletions(-)
>>
>> Âdiff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c
>> Âindex 4f254bc..f715f46 100644
>> Â--- a/tools/net/bpf_dbg.c
>> Â+++ b/tools/net/bpf_dbg.c
>> Â@@ -1213,7 +1213,7 @@ static int cmd_disassemble(char *line_string)
>>
>> ÂÂÂÂÂÂÂÂÂÂif (!bpf_prog_loaded())
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn CMD_ERR;
>> Â- if (strlen(line_string) > 0 &&
>> Â+ if (strlen(line_string) > 0 &&)
>
> ÂÂÂÂHave tried to you compile that? :-/

Yes, i compiled but I apologize if there was NAK.
Also, checkpatch give a error.

I could be wrong, will review again.

Best Regards!

>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ(line = strtoul(line_string, NULL, 10)) < bpf_prog_len)
>
> ÂÂÂÂI think the code was correct before your patch...
>
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂsingle_line = true;
>> ÂÂÂÂÂÂÂÂÂÂif (single_line)
>
> MBR, Sergei

~Ozgur