Re: [GIT PULL] KVM fixes for 4.10 merge window

[Paolo Bonzini]

----- Original Message -----
> From: "Pan Xinhui" <xinhui@xxxxxxxxxxxxxxxxxx>
> To: "Linus Torvalds" <torvalds@xxxxxxxxxxxxxxxxxxxx>, "Paolo Bonzini" <pbonzini@xxxxxxxxxx>
> Cc: "Linux Kernel Mailing List" <linux-kernel@xxxxxxxxxxxxxxx>, "Radim KrÄmÃÅ" <rkrcmar@xxxxxxxxxx>, "KVM list"
> <kvm@xxxxxxxxxxxxxxx>
> Sent: Saturday, December 17, 2016 4:09:16 AM
> Subject: Re: [GIT PULL] KVM fixes for 4.10 merge window
> 
> 
> 
> å 2016/12/17 03:42, Linus Torvalds åé:
> > On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
> >>
> >>   git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
> >
> > This piece-of-shit branch has obviously never been even compile-tested:
> >
> >   arch/x86/kernel/kvm.c: In function â__kvm_vcpu_is_preemptedâ:
> >   arch/x86/kernel/kvm.c:596:14: error: âstruct kvm_steal_timeâ has no
> > member named âpreemptedâ
> >
> hi, Linus
> 	oh, my bad also. I introduce this struct member and use it in same patch.
> Better to separate tem into two patches. I make one fix patch below. sorry
> again.

Hi Xinhui, don't worry it's purely my fault. :)

> 	I have known where is th problem, I think if we can set this ->preempted
> 	later after preempted_enable()
> or just introduce something like write_guest_nosleep (per cpu memory section
> in guest, so there is no page_fault or any other cannot sleep problems)?

Yes there is already kvm_read_guest_inatomic, we can add an equivalent one
for writes.  It will be for 4.11 anyway, so there's time.

Paolo