Re: [PATCH] scripts: checkincludes: add exit message for no duplicates found

From: Michal Marek
Date: Mon Dec 19 2016 - 05:47:52 EST


On 2016-12-18 13:35, Cheah Kok Cheong wrote:
> If no duplicates found, inform user.
>
> Signed-off-by: Cheah Kok Cheong <thrust73@xxxxxxxxx>
> ---
> scripts/checkincludes.pl | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/scripts/checkincludes.pl b/scripts/checkincludes.pl
> index 97b2c61..2bf234c 100755
> --- a/scripts/checkincludes.pl
> +++ b/scripts/checkincludes.pl
> @@ -37,6 +37,13 @@ if ($#ARGV >= 1) {
> }
> }
>
> +my $dup_counter = 0;
> +
> +sub nodup_count {
> + ++$dup_counter;
> + return;
> +}

I don't think it's necessary to have a function only to increment a
variable.

Michal