Re: [PATCH v2] USB: serial: f81534: Detect errors from f81534_logic_to_phy_port()

[Johan Hovold]

On Sun, Dec 18, 2016 at 10:19:28AM +0100, Geert Uytterhoeven wrote:
> With gcc 4.1.2:
> 
>     drivers/usb/serial/f81534.c: In function âf81534_port_probeâ:
>     drivers/usb/serial/f81534.c:1250: warning: comparison is always false due to limited range of data type
> 
> f81534_logic_to_phy_port() may return a negative error value, which is
> ignored by assigning it to u8 f81534_port_private.phy_num.
> 
> Use an intermediate variable of type int to fix this.
> While at it, forward the actual error code instead of converting it to
> -ENODEV, and drop the useless check for F81534_NUM_PORT, as the callee
> always returns a valid port number in case of success.
> 
> Fixes: 0c9bd6004d258d46 ("USB: serial: add Fintek F81532/534 driver")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> v2:
>   - Drop useless check for F81534_NUM_PORT.

Thanks for the update. I'll queue this one up for -rc2.

Johan