Re: [PATCH 1/1] xfs: silent -Wformat-security warning

[Christoph Hellwig]

On Mon, Dec 19, 2016 at 02:41:11PM +0100, Nicolas Iooss wrote:
> When building the XFS driver with clang, the compiler reports a
> -Wformat-security warning in xlog_recover_validate_buf_type() because
> xfs_warn() is being called with a non-literal string. Even though
> variable warnmsg is always initialized as a constant string without any
> '%' character, silent the warning by calling xfs_warn with "%s" format
> string.
> 
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>

Looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>