Re: [PATCH] sched/fair: fix calc_cfs_shares fixed point arithmetics

[Peter Zijlstra]

On Tue, Dec 20, 2016 at 02:04:34PM +0100, Dietmar Eggemann wrote:
> Hi Samuel,
> 
> On 12/20/2016 12:45 AM, Samuel Thibault wrote:
> >Paul Turner, on Mon 19 Dec 2016 15:32:15 -0800, wrote:
> >>On Mon, Dec 19, 2016 at 3:29 PM, Samuel Thibault
> >><samuel.thibault@xxxxxxxxxxxx> wrote:
> >>>Paul Turner, on Mon 19 Dec 2016 15:26:19 -0800, wrote:
> 
> [...]
> 
> >>The MIN_SHARES you are seeing here is overloaded.
> >>In the unscaled case this needs to be MIN_SHARES, and in the scaled
> >>case, the subdivision of the scaled values must still be >=2.
> >
> >Ok, now I understand.  I have to say this overloading is confusing.
> >
> >Samuel
> 
> this had been already discussed back in August when I posted the original
> patch.

Maybe we should put a comment in to avoid getting more of these ;-)