Re: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359

[Larry Finger]

On 12/20/2016 05:21 AM, Kalle Valo wrote:
> Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes:
>
> > With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
> > kfree_skb"), the method used to free an skb was changed because the
> > kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb()
> > guards against a NULL value for the argument. Routine dev_kfree_skb_irq()
> > does not, and a test is needed to prevent kernel panics.
> >
> > Fixes: commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>
> This should be:
>
> Fixes: e49656147359 ("rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>
> > Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> > Cc: Stable <stable@xxxxxxxxxxxxxxx> (4.9+)
>
> And this:
>
> Cc: Stable <stable@xxxxxxxxxxxxxxx> # 4.9+
>
> I can fix both of them.
>
> > Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> > ---
> > Kalle,
> >
> > This change should be sent to mainline during the 4.10 merge period,
> > or as soon as possible.
>
> Ok, I'll queue this to 4.10. Most likely I'll send a pull request to
> Dave later this week or so.

Thanks for the suggested changes, and for the quick action.

Larry