Re: [PATCH v2] ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output

[David Miller]

From: Zheng Li <lizheng043@xxxxxxxxx>
Date: Mon, 12 Dec 2016 09:56:05 +0800

> From: zheng li <james.z.li@xxxxxxxxxxxx>
> 
> There is an inconsistent conditional judgement in __ip_append_data and
> ip_finish_output functions, the variable length in __ip_append_data just
> include the length of application's payload and udp header, don't include
> the length of ip header, but in ip_finish_output use
> (skb->len > ip_skb_dst_mtu(skb)) as judgement, and skb->len include the
> length of ip header.
> 
> That causes some particular application's udp payload whose length is
> between (MTU - IP Header) and MTU were fragmented by ip_fragment even
> though the rst->dev support UFO feature.
> 
> Add the length of ip header to length in __ip_append_data to keep
> consistent conditional judgement as ip_finish_output for ip fragment.
> 
> Signed-off-by: Zheng Li <james.z.li@xxxxxxxxxxxx>

Applied, thanks.