Re: [PATCH] kernel: sys: fix out of place EXPORT_SYMBOL call

[Michal Hocko]

On Tue 20-12-16 14:39:19, Thomas Casey wrote:
> Fixes two instances of EXPORT_SYMBOL not being called immediately after
> the initialization of its argument

What does this fix actually?

> Signed-off-by: Thomas Casey <tqcasey@xxxxxxxxx>
> ---
>  kernel/sys.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/kernel/sys.c b/kernel/sys.c
> index 9758892a2d09..8afd3e341f9b 100644
> --- a/kernel/sys.c
> +++ b/kernel/sys.c
> @@ -110,9 +110,8 @@
>   */
>  
>  int overflowuid = DEFAULT_OVERFLOWUID;
> -int overflowgid = DEFAULT_OVERFLOWGID;
> -
>  EXPORT_SYMBOL(overflowuid);
> +int overflowgid = DEFAULT_OVERFLOWGID;
>  EXPORT_SYMBOL(overflowgid);
>  
>  /*
> @@ -121,9 +120,8 @@ EXPORT_SYMBOL(overflowgid);
>   */
>  
>  int fs_overflowuid = DEFAULT_FS_OVERFLOWUID;
> -int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
> -
>  EXPORT_SYMBOL(fs_overflowuid);
> +int fs_overflowgid = DEFAULT_FS_OVERFLOWUID;
>  EXPORT_SYMBOL(fs_overflowgid);
>  
>  /*
> -- 
> 2.11.0
> 

-- 
Michal Hocko
SUSE Labs