Re: [PATCH 2/2] efi: efi_mem_reserve(): don't reserve through memblock after mm_init()

From: Nicolai Stange
Date: Thu Dec 22 2016 - 05:26:45 EST


Mika Penttilà <mika.penttila@xxxxxxxxxxxx> writes:

> On 21.12.2016 20:28, Nicolai Stange wrote:
>> /**
>> * efi_mem_reserve - Reserve an EFI memory region
>> @@ -419,7 +422,7 @@ void __init __weak efi_arch_mem_reserve(phys_addr_t addr, u64 size) {}
>> */
>> void __init efi_mem_reserve(phys_addr_t addr, u64 size)
>> {
>> - if (!memblock_is_region_reserved(addr, size))
>> + if (slab_is_available() && !memblock_is_region_reserved(addr, size))
>> memblock_reserve(addr, size);
> Maybe !slab_is_available() ?

You're right, thanks for catching this!

Fixed in v2 at http://lkml.kernel.org/r/20161222102340.2689-2-nicstange@xxxxxxxxx

Thanks,

Nicolai