Re: [PATCH] MIPS: ralink: fix incorrect assignment on ralink_soc

From: John Crispin
Date: Fri Dec 23 2016 - 00:39:12 EST




On 23/12/2016 00:52, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> ralink_soc sould be assigned to RT3883_SOC, replace incorrect
> comparision with assignment.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Acked-by: John Crispin <john@xxxxxxxxxxx>

i thought i had sent this fix upstream ages ago. luckily this bug never
caused any error as none of the code checking ralink_soc checks for
rt3883. its used for the rt3x5x family.

John


> ---
> arch/mips/ralink/rt3883.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ralink/rt3883.c b/arch/mips/ralink/rt3883.c
> index 141c597..f869052 100644
> --- a/arch/mips/ralink/rt3883.c
> +++ b/arch/mips/ralink/rt3883.c
> @@ -157,5 +157,5 @@ void prom_soc_init(struct ralink_soc_info *soc_info)
>
> rt2880_pinmux_data = rt3883_pinmux_data;
>
> - ralink_soc == RT3883_SOC;
> + ralink_soc = RT3883_SOC;
> }
>
his