Re: [PATCH] mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM

[Neil Armstrong]

On 01/02/2017 03:58 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> 
> Fix build errors on arch/um, which does not support HAS_IOMEM,
> while the oxnas_nand.c driver uses interfaces that are
> supplied by HAS_IOMEM.
> 
> (loadable module build:)
> ERROR: "devm_ioremap_resource" [drivers/mtd/nand/oxnas_nand.ko] undefined!
> or (built-in build:)
> drivers/built-in.o: In function `oxnas_nand_probe':
> drivers/mtd/nand/oxnas_nand.c:102: undefined reference to `devm_ioremap_resource'
> 
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>
> Cc: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Cc:	Jeff Dike <jdike@xxxxxxxxxxx>
> Cc:	Richard Weinberger <richard@xxxxxx>
> Cc:	user-mode-linux-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc:	linux-mtd@xxxxxxxxxxxxxxxxxxx
> ---
>  drivers/mtd/nand/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- lnx-410-rc2.orig/drivers/mtd/nand/Kconfig
> +++ lnx-410-rc2/drivers/mtd/nand/Kconfig
> @@ -426,6 +426,7 @@ config MTD_NAND_ORION
>  
>  config MTD_NAND_OXNAS
>  	tristate "NAND Flash support for Oxford Semiconductor SoC"
> +	depends on HAS_IOMEM
>  	help
>  	  This enables the NAND flash controller on Oxford Semiconductor SoCs.
>  
> 

Thanks Randy,

Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>