Re: [PATCH] taint/module: Fix problems when out-of-kernel driver defines true or false

From: Petr Mladek
Date: Mon Jan 02 2017 - 05:51:51 EST


On Sun 2017-01-01 20:25:25, Larry Finger wrote:
> Commit 7fd8329ba502 ("taint/module: Clean up global and module taint
> flags handling") used the key words true and false as character members
> of a new struct. These names cause problems when out-of-kernel modules
> such as VirtualBox include their own definitions of true and false.
>
> Fixes: 7fd8329ba502 ("taint/module: Clean up global and module taint flags handling")
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Cc: Petr Mladek <pmladek@xxxxxxxx>
> Cc: Jessica Yu <jeyu@xxxxxxxxxx>
> Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

I like this variant a bit more than the tainted/untainted one.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr