Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end

From: David Miller
Date: Tue Jan 03 2017 - 09:55:13 EST


From: Reiter Wolfgang <wr0112358@xxxxxxxxx>
Date: Tue, 3 Jan 2017 01:39:10 +0100

> Final nlmsg_len field update must reflect inserted net_dm_drop_point
> data.
>
> This patch depends on previous patch:
> "drop_monitor: add missing call to genlmsg_end"
>
> Signed-off-by: Reiter Wolfgang <wr0112358@xxxxxxxxx>

I don't understand why the current code doesn't work properly.

All over the tree, the pattern is:

x = genlmsg_put(skb, ...);
...
genlmsg_end(skb, x);

And that is exactly what the code is doing right now.