Re: [f2fs-dev] [PATCH 01/10] f2fs: reassign new segment for mode=lfs

From: Chao Yu
Date: Tue Jan 03 2017 - 22:25:58 EST


Hi Jaegeuk,

On 2016/12/31 2:51, Jaegeuk Kim wrote:
> Otherwise we can remain wrong curseg->next_blkoff, resulting in fsck failure.

Could you explain more about this case?

Thanks,

>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> ---
> fs/f2fs/segment.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index be9e4d244d75..4e5ffe1d97e4 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1428,9 +1428,6 @@ void allocate_new_segments(struct f2fs_sb_info *sbi)
> unsigned int old_segno;
> int i;
>
> - if (test_opt(sbi, LFS))
> - return;
> -
> for (i = CURSEG_HOT_DATA; i <= CURSEG_COLD_DATA; i++) {
> curseg = CURSEG_I(sbi, i);
> old_segno = curseg->segno;
>