Re: [PATCH] Staging: fbtft: hx8340bn: Style fix, octal not decimal permissions

[Andy Shevchenko]

On Wed, Jan 4, 2017 at 3:20 AM, Derek Robson <robsonde@xxxxxxxxx> wrote:
> Fixed coding style issue, found with Checkpatch.pl
> changed permissions to octal style.

You missed SoB.

> @@ -37,7 +37,7 @@
>                         "3 3 17 8 4 7 05 7 6 0 3 1 6 0 0 "
>
>  static bool emulate;
> -module_param(emulate, bool, 0);
> +module_param(emulate, bool, 0000);

Why not to allow reading as well?

>  MODULE_PARM_DESC(emulate, "Force emulation in 9-bit mode");

-- 
With Best Regards,
Andy Shevchenko