Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

[Srinivas Pandruvada]

On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote:
> On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote:
> > 
> > Intel ISHFW supports many different clients, in
> > hid/intel-ish-hid/ishtp bus driver, it creates following client
> > devices:
> > HID client:
> > 	interface of sensor configure and sensor event report.
> > SMHI client:
> > 	interface of sensor calibration, ISHFW debug, ISHFW performance
> > 	analysis and manufacture support.
> > Trace client:
> > 	interface of ISHFW debug log output.
> > Trace configure client:
> > 	interface of ISHFW debug log configuration, such as output
> > port,
> > 	log level, filter.
> > ISHFW loader client:
> > 	interface of customized ISHFW loader.
> > HID client has been handle by hid/intel-ish-hid/intel-ishtp-hid
> > client
> > driver, and rest of the clients export interface using
> > miscellaneous
> > drivers. This interface is used by user space tools for debugging
> > and
> > calibration of sensors.
> > 
> > Signed-off-by: Even Xu <even.xu@xxxxxxxxx>
> > Reviewed-by: Andriy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxx
> > om>
> > ---
> > Âdrivers/misc/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> > Âdrivers/misc/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> > Âdrivers/misc/intel-ish-client/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ15 +
> > Âdrivers/misc/intel-ish-client/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ8 +
> > Â.../misc/intel-ish-client/intel-ishtp-clients.cÂÂÂÂ| 884
> > +++++++++++++++++++++
> > Âinclude/uapi/linux/intel-ishtp-clients.hÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ73 ++
> 
> 
> Why create a whole new subdirectory for just one .c file?ÂÂIs that
> really needed?
The other option is to move this .c file toÂdrivers/hid/intel-ish-hid/.
I think the folders inside drivers/hid/ is mostly for just implementing
transport layer for hid devices.


> 
> And I'm not quite sure why you need a misc driver, what exactly is
> this
> code doing?
As described in the description, this driver is a companion driver for
ISH user space tools for calibration, production and debug.

Basically the ISH provided a standalone low power processor to
developers and manufacturers Âto do download some custom algorithms for
sensors, which may not be compliant to USB HID sensor specifications
(mostly for IOT space). In that case the user space for those can
communicate using misc driver interface, without adding new kernel
drivers.

Thanks,
Srinivas