Re: [PATCH net-next] net: phy: add extension of phy-mode for XLGMII

From: Florian Fainelli
Date: Wed Jan 04 2017 - 13:51:47 EST


On 01/04/2017 10:42 AM, David Miller wrote:
> From: Jie Deng <Jie.Deng1@xxxxxxxxxxxx>
> Date: Wed, 4 Jan 2017 13:04:04 +0800
>
>> The Synopsys DWC_xlgmac core provides a multiplexed 40-Gigabit
>> Media-Independent Interface (XLGMII, an IEEE 802.3 Clause 81
>> compliant reconciliation sub-layer) for communication with
>> the 100/50/40/25-Gigabit PHY and 10-Gigabit Media-Independent
>> Interface (XGMII, an IEEE 802.3 Clause 46 compliant reconciliation
>> sub-layer) for communication with the 10-Gigabit PHY.
>>
>> Currently, There are only interface mode definitions for "xgmii".
>> This patch adds the definitions for the PHY layer to recognize
>> "xlgmii" as a valid PHY interface.
>>
>> Signed-off-by: Jie Deng <jiedeng@xxxxxxxxxxxx>
>
> It makes no sense to add these definitions unless you also submit
> uses of them alongside at the same time.

Correct, also, this is incomplete, you must include a change to
Documentation/devicetree/bindings/net/ethernet.txt to reflect this new mode.

Thank you
--
Florian