Re: [PATCH RESEND] power: gpio_charger: switch to using GPIO descriptors

From: Sebastian Reichel
Date: Wed Jan 04 2017 - 16:22:36 EST


Hi Linus,

On Mon, Dec 26, 2016 at 09:18:55PM +0100, Linus Walleij wrote:
> The GPIO charger is using a mix of the legacy GPIO interface
> and <linux/of_gpio.h> which is not the modern way to use GPIOs.
>
> Refactor like this:
>
> - Use a GPIO descriptor for the GPIO line used to monitor the
> charger.
> - Fetch the descriptor with devm_gpiod_get() as the first
> method.
> - If this fails and we are *not* using device tree, then
> start looking to see if we can use platform data instead.
> - After looking up and requesting a GPIO number with the
> legacy API, convert it to a descriptor.
>
> This way we can later isolate and drop the legacy code as
> more platforms move over to using descriptors.
>
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> Cc: Heiko Stuebner <heiko@xxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for your patch. I have queued it into power-supply's
for-next branch:

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=for-next

-- Sebastian

Attachment: signature.asc
Description: PGP signature