Re: [PATCHv7 8/8] printk: convert the rest to printk-safe

From: Sergey Senozhatsky
Date: Wed Jan 04 2017 - 20:00:53 EST


On (01/04/17 17:28), Petr Mladek wrote:
> On Tue 2016-12-27 23:16:11, Sergey Senozhatsky wrote:
> > This patch converts the rest of logbuf users (which are
> > out of printk recursion case, but can deadlock in printk).
> > To make printk-safe usage easier the patch introduces 4
> > helper macros:
> > - logbuf_lock_irq()/logbuf_unlock_irq()
> > lock/unlock the logbuf lock and disable/enable local IRQ
> >
> > - logbuf_lock_irqsave(flags)/logbuf_unlock_irqrestore(flags)
> > lock/unlock the logbuf lock and saves/restores local IRQ state
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
> I like that it is so straigforward using the new macros. It is great
> that you discovered this before we finished the patchset.
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

thanks.

-ss