Re: [PATCH 1/3] linux/const.h: move UL() macro to include/linux/const.h
From: Masahiro Yamada
Date: Wed Jan 04 2017 - 21:23:35 EST
Hi Geert,
2017-01-04 18:27 GMT+09:00 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>:
> Hi Yamada-san,
>
> On Wed, Jan 4, 2017 at 9:55 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> Some architectures are duplicating the definition of UL():
>>
>> #define UL(x) _AC(x, UL)
>>
>> This is not actually arch-specific, so it will be useful to move it
>> to a common header. Currently, we only have the uapi variant for
>> linux/const.h, so I am creating include/linux/const.h.
>>
>> I am also adding _UL(x), _ULL(x), ULL(x) because _AC() is used for
>> UL in most places (and ULL in some places). I expect _AC(..., UL)
>> will be replaced with _UL(...) or UL(...). The underscore-prefixed
>> one should be used for exported headers.
>>
>> Note:
>> I renamed UL(x) in arch/m68k/mm/init.c, where it is used for a
>> different meaning.
>
> Shouldn't that be a separate (prerequisite) patch?
Yes, I did so in v2.
Thanks!
--
Best Regards
Masahiro Yamada