Re: [PATCH 1/2] mfd: micon: Add Buffalo Kurobox Pro, Terastation II Pro/Live driver

From: Florian Fainelli
Date: Wed Jan 04 2017 - 21:33:46 EST


Le 01/04/17 Ã 03:22, Lee Jones a Ãcrit :
> On Wed, 28 Dec 2016, Florian Fainelli wrote:
>
>> This driver is currently only used to reboot the devices, but the
>> microcontroller hanging off UART1 on the Buffalo Kurobox Pro and
>> Terastation II Pro/Live is capable of a lot more than that, which we
>> will support in subsequent patches. For now, just add the reboot
>> functionality to make the kernel reboot correctly.
>
> This is not an MFD driver. You have written a UART driver.
>
> Please relocate it to drivers/char/tty/serial.

Not that simple, and as explained in the cover letter the UART attached
micro controller can do a lot more than just reboot the machine, but
someone else is working on the driver, so this patch series can be ignored.
--
Florian