Re: [PATCH] x86, trace: Add __irq_entry annotation to x86's platform IRQ handlers

From: Ingo Molnar
Date: Thu Jan 05 2017 - 02:59:33 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 4 Jan 2017 12:20:33 +0100
> Daniel Bristot de Oliveira <bristot@xxxxxxxxxx> wrote:
>
> > This patch adds the __irq_entry annotation to the defaults x86's
> > platform IRQ handlers. ftrace's function_graph tracer uses the
> > __irq_entry annotation to notify the entry and return of IRQ
> > handlers.
> >
> > For example, before the patch:
> > 354549.667252 | 3) d..1 | default_idle_call() {
> > 354549.667252 | 3) d..1 | arch_cpu_idle() {
> > 354549.667253 | 3) d..1 | default_idle() {
> > 354549.696886 | 3) d..1 | smp_trace_reschedule_interrupt() {
> > 354549.696886 | 3) d..1 | irq_enter() {
> > 354549.696886 | 3) d..1 | rcu_irq_enter() {
> >
> > After the patch:
> > 366416.254476 | 3) d..1 | arch_cpu_idle() {
> > 366416.254476 | 3) d..1 | default_idle() {
> > 366416.261566 | 3) d..1 ==========> |
> > 366416.261566 | 3) d..1 | smp_trace_reschedule_interrupt() {
> > 366416.261566 | 3) d..1 | irq_enter() {
> > 366416.261566 | 3) d..1 | rcu_irq_enter() {
> >
> > KASAN also uses this annotation. The smp_apic_timer_interrupt
> > was already annotated.
>
> Acked-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>
> Thomas or Ingo, want to take this in tip?

Yeah, queued it up for v4.11.

Thanks,

Ingo