Re: [PATCH] x86/microcode/intel: Fix allocation size of struct ucode_patch

[Borislav Petkov]

On Thu, Jan 05, 2017 at 01:03:51AM +0000, Junichi Nomura wrote:
> We allocate struct ucode_patch here.
> 
> "size" is a size of microcode data and used for kmemdup() later
> in this function.
> 
> Signed-off-by: Jun'ichi Nomura <j-nomura@xxxxxxxxxxxxx>
> Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
> 
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index aee3cb5..042f329 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -150,7 +150,7 @@ static struct ucode_patch *__alloc_microcode_buf(void *data, unsigned int size)
>  {
>  	struct ucode_patch *p;
>  
> -	p = kzalloc(size, GFP_KERNEL);
> +	p = kzalloc(sizeof(struct ucode_patch), GFP_KERNEL);
>  	if (!p)
>  		return ERR_PTR(-ENOMEM);
>  
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.