Re: [PATCH] Fix SLAB freelist randomization duplicate entries

From: Andrew Morton
Date: Thu Jan 05 2017 - 19:34:35 EST


On Tue, 3 Jan 2017 10:19:08 -0800 Thomas Garnier <thgarnie@xxxxxxxxxx> wrote:

> This patch fixes a bug in the freelist randomization code. When a high
> random number is used, the freelist will contain duplicate entries. It
> will result in different allocations sharing the same chunk.

Important: what are the user-visible runtime effects of the bug?

> Fixes: c7ce4f60ac19 ("mm: SLAB freelist randomization")
> Signed-off-by: John Sperbeck <jsperbeck@xxxxxxxxxx>
> Reviewed-by: Thomas Garnier <thgarnie@xxxxxxxxxx>

This should have been signed off by yourself.

I'm guessing that the author was in fact John? If so, you should
indicate this by putting his From: line at the start of the changelog.
Otherwise, authorship will default to the sender (ie, yourself).