Re: [PATCH 2/2] phy: rockchip-emmc: try to get drive impedance from DT
From: Doug Anderson
Date: Thu Jan 05 2017 - 19:57:22 EST
Hi,
On Thu, Jan 5, 2017 at 1:31 AM, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx> wrote:
> Try to get drive impedance from DT and use it, otherwise
> use 50ohm by default in order not to break the existing boards
> as 50ohm works fine for them already.
>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> ---
>
> drivers/phy/phy-rockchip-emmc.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
I could have sworn that you somehow needed to make sure that the eMMC
part itself needed to also be updated to be told the matching drive
impedance so you don't get a mismatch. How do you make that work?
...or am I just confused. I meant to try to dig more, but ran out of
time today. :(
-Doug