Re: [v1] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use 'linux/io.h'.

From: Arvind Yadav
Date: Fri Jan 06 2017 - 01:20:58 EST


Thanks for your suggestion :).
I have done the changes as per your concern . Please review it.

Thanks :)
-Arvind

On Thursday 05 January 2017 05:35 PM, Greg KH wrote:
On Thu, Jan 05, 2017 at 05:25:05PM +0530, Arvind Yadav wrote:
Please find my comment below.
Where? What happened to your email quoting?

Thanks
-Arvind

On Thursday 05 January 2017 05:16 PM, Greg KH wrote:
On Thu, Jan 05, 2017 at 04:09:24PM +0530, Arvind Yadav wrote:
Make uniform definition of ioremap, ioremap_wc, ioremap_wt and
ioremap_cache, tree-wide.
That doesn't make much sense, and doesn't match the subject: or the
patch itself.
-- Please refer the commit which is already in main-lined.
commit 2584cf83578c26db144730ef498f4070f82ee3ea
Ah, here it is, please quote stuff correctly.

If you are referring to something else, great, then say so in the commit
itself. Every commit should be self-explanatory, how am I supposed to
know this.

And this text still doesn't make sense to me, please fix.

And what is with the "[v1]"?
---V1 is stands for patch set version 1
Please read Documentation/SubmittingPatches for how to properly label
patches, don't make new things up, we have too many different developers
(i.e. 4000+) for everyone to do their own unique thing. :)

thanks,

greg k-h