Re: [PATCH net-next] net: make ndo_get_stats64 a void function

From: kbuild test robot
Date: Fri Jan 06 2017 - 04:11:13 EST


Hi Stephen,

[auto build test WARNING on net-next/master]

url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-ndo_get_stats64-a-void-function/20170106-160123
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa

All warnings (new ones prefixed by >>):

drivers/net/macsec.c: In function 'macsec_get_stats64':
>> drivers/net/macsec.c:2897:3: warning: 'return' with a value, in function returning void
return s;
^

vim +/return +2897 drivers/net/macsec.c

c09440f7 Sabrina Dubroca 2016-03-11 2881 unsigned int extra = macsec->secy.icv_len + macsec_extra_len(true);
c09440f7 Sabrina Dubroca 2016-03-11 2882
c09440f7 Sabrina Dubroca 2016-03-11 2883 if (macsec->real_dev->mtu - extra < new_mtu)
c09440f7 Sabrina Dubroca 2016-03-11 2884 return -ERANGE;
c09440f7 Sabrina Dubroca 2016-03-11 2885
c09440f7 Sabrina Dubroca 2016-03-11 2886 dev->mtu = new_mtu;
c09440f7 Sabrina Dubroca 2016-03-11 2887
c09440f7 Sabrina Dubroca 2016-03-11 2888 return 0;
c09440f7 Sabrina Dubroca 2016-03-11 2889 }
c09440f7 Sabrina Dubroca 2016-03-11 2890
1e665d95 Stephen Hemminger 2017-01-05 2891 static void macsec_get_stats64(struct net_device *dev,
c09440f7 Sabrina Dubroca 2016-03-11 2892 struct rtnl_link_stats64 *s)
c09440f7 Sabrina Dubroca 2016-03-11 2893 {
c09440f7 Sabrina Dubroca 2016-03-11 2894 int cpu;
c09440f7 Sabrina Dubroca 2016-03-11 2895
c09440f7 Sabrina Dubroca 2016-03-11 2896 if (!dev->tstats)
c09440f7 Sabrina Dubroca 2016-03-11 @2897 return s;
c09440f7 Sabrina Dubroca 2016-03-11 2898
c09440f7 Sabrina Dubroca 2016-03-11 2899 for_each_possible_cpu(cpu) {
c09440f7 Sabrina Dubroca 2016-03-11 2900 struct pcpu_sw_netstats *stats;
c09440f7 Sabrina Dubroca 2016-03-11 2901 struct pcpu_sw_netstats tmp;
c09440f7 Sabrina Dubroca 2016-03-11 2902 int start;
c09440f7 Sabrina Dubroca 2016-03-11 2903
c09440f7 Sabrina Dubroca 2016-03-11 2904 stats = per_cpu_ptr(dev->tstats, cpu);
c09440f7 Sabrina Dubroca 2016-03-11 2905 do {

:::::: The code at line 2897 was first introduced by commit
:::::: c09440f7dcb304002dfced8c0fea289eb25f2da0 macsec: introduce IEEE 802.1AE driver

:::::: TO: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>
:::::: CC: David S. Miller <davem@xxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip