Re: [PATCH v6 08/18] iommu/vt-d: Implement reserved region get/put callbacks

From: Joerg Roedel
Date: Fri Jan 06 2017 - 07:49:20 EST


On Fri, Jan 06, 2017 at 12:45:54PM +0100, Auger Eric wrote:
> On 06/01/2017 12:01, Joerg Roedel wrote:
> > On Thu, Jan 05, 2017 at 07:04:36PM +0000, Eric Auger wrote:

> > That is different from what AMD does, can you also report the RMRR
> > regions for the device here (as direct-map regions)?
>
> if I return RMRR regions as direct mapped regions,
> iommu_group_create_direct_mappings will perform the 1-1 mapping.

No, this will not happen until the Intel IOMMU driver returns valid
IOMMU_DOMAIN_DMA type domains.

> I am not familiar with the intel-iommu code but I guess this job
> currently is done in the intel driver:
> iommu_prepare_rmrr_dev -> iommu_prepare_identity_map
> ->domain_prepare_identity_map -> iommu_domain_identity_map?

Right, this is done in the Intel driver atm.



Joerg