Re: [PATCHv1 5/7] TAP: Extending tap device create/destroy APIs

[Eric Dumazet]

On Fri, 2017-01-06 at 14:33 -0800, Sainath Grandhi wrote:

> +static int tap_list_add(dev_t major, const char *device_name)
> +{
> +	int err = 0;
> +	struct major_info *tap_major;
> +
> +	tap_major = kzalloc(sizeof(*tap_major), GFP_ATOMIC);
> +
> +	tap_major->major = MAJOR(major);
> +


kzalloc() can perfectly return NULL.

You do not want to crash it that happens.