Re: [PATCH] usb: dwc2: use u32 for DT binding parameters

[Leo Yan]

On Fri, Jan 06, 2017 at 07:30:28PM -0800, John Youn wrote:
> On 1/6/2017 1:52 PM, John Stultz wrote:
> > On Fri, Jan 6, 2017 at 4:45 AM, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
> >> Commit 05ee799f2021 ("usb: dwc2: Move gadget settings into core_params")
> >> changes to type u16 for DT binding "g-rx-fifo-size" and
> >> "g-np-tx-fifo-size" but use type u32 for "g-tx-fifo-size". Finally the
> >> the first two parameters cannot be passed successfully with wrong data
> >> format. This is found the data transferring broken on 96boards Hikey.
> >>
> >> This patch is to change all parameters to u32 type, and verified on
> >> Hikey board the DT parameters can pass successfully.
> >>
> >> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> > 
> > Nice!
> > 
> > This patch (while it doesn't apply cleanly to v4.10-rc2) does resolve
> > the regression I reported earlier here:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__www.spinics.net_lists_linux-2Dusb_msg150766.html&d=DgIBaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=U3o8uKoKhWme5_V9D-eeCkB11BFwt4KvWztBgdE9ZpA&m=pIpbe7JcuPH0X7-CYbBt2U3yE2WPSPtrGaMQRtcvQM0&s=hYurvvfAzlq9WTDnKKUznSRb5thSAvIO9doLJOzfUSo&e= 
> > 
> > I didn't see the slight shift to u16s there.
> > 
> > Leo, does the patch need a respin, or is it against Linus' HEAD and my
> > tree is stale?

Yeah, I should respin it.

> > Anyway, after re-applying it to my tree:
> > Tested-by: John Stultz <john.stultz@xxxxxxxxxx>
> > 
> 
> Thanks Leo and John.
> 
> I just sent out a rebased version for Felipe to pick up.

Thanks a lot for both of you :)

> Regards,
> John
>