Re: [PATCH] usb: storage: ene_ub6250: remove unused variable

From: Greg Kroah-Hartman
Date: Sun Jan 08 2017 - 06:33:02 EST


On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote:
> On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> > > The variable Newblk was only being assigned some value but was never
> > > used after that.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@xxxxxxxxxxxxxxx>
> > > ---
> > > drivers/usb/storage/ene_ub6250.c | 2 --
> > > 1 file changed, 2 deletions(-)
> >
> > from and signed-off-by does not match :(
> >
> > Same with your other usb patch...
> >
>
> I can add the From: tag in the patch. But this is from the last time we had
> this same conversation.
>
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html

I can't remember an email thread from last week, or even yesterday, let
alone from almost a year ago.

I suggest you fix your email server so we don't have the same
conversation next week, or use the From: line in the patch which is what
I am expecting people to do for crappy email servers like this. :)

thanks,

greg k-h