Re: [V1] ata: sata_mv:- Handle return value of devm_ioremap.

From: Tejun Heo
Date: Sun Jan 08 2017 - 13:51:53 EST


On Sat, Jan 07, 2017 at 12:52:57AM +0200, Andy Shevchenko wrote:
> On Fri, Jan 6, 2017 at 10:46 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> > On Mon, Dec 12, 2016 at 11:13:27PM +0530, Arvind Yadav wrote:
> >> Here, If devm_ioremap will fail. It will return NULL.
> >> Then hpriv->base = NULL - 0x20000; Kernel can run into
> >> a NULL-pointer dereference. This error check will avoid
> >> NULL pointer dereference.
> >>
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> >
> > Applied to libata/for-4.10-fixes.
>
> Hold on, why not to convert to devm_ioremap_resource() ?

Care to send the patch?

Thanks.

--
tejun