Re: drivers/net/wireless/intel/iwlwifi/pcie/trans.c: 2 * suspicious code ?
From: Luca Coelho
Date: Mon Jan 09 2017 - 06:17:14 EST
On Fri, 2017-01-06 at 17:47 +0000, David Binderman wrote:
> Hello there,
Hi David,
> 1.
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2039:14: warning: decrement of a boolean expression [-Wbool-operation]
>
> Source code is
>
> txq->block--;
>
> Maybe someone got a bool and a int mixed up ?
>
> 2.
>
> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:2045:14: warning: increment of a boolean expression [-Wbool-operation]
>
> Duplicate a few lines further down.
Emmanuel has fixed this in our internal tree and I'll be sending it out
together with our normal upstreaming process.
Thanks for reporting!
--
Cheers,
Luca.